Skip to content

Quickfix/efvignette/logscale #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kristinawlai wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Quickfix/efvignette/logscale #308

kristinawlai wants to merge 12 commits into from

Conversation

@kristinawlai
Copy link
Collaborator

@kristinawlai kristinawlai commented Oct 12, 2024 •
edited
Loading

Specifying log scale in second cross-sectional antibody data plot

@codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
R/autoplot.summary.seroincidence.by.bar.R 0.00% 22 Missing ⚠️
Files with missing lines Coverage Δ
R/autoplot.summary.seroincidence.by.bar.R 0.00% <0.00%> (ø)

@kristinawlai kristinawlai marked this pull request as ready for review October 12, 2024 23:37
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

📖 https://ucd-serg.github.io/serocalculator/preview/pr308
Preview documentation for this PR (at commit 9fe73c2)

d-morrison
d-morrison reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@d-morrison d-morrison left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Two questions:

  1. Why are we applying the log scale manually instead of with the log = TRUE option for autoplot.pop_data()?
  2. @kaiemjoy, is this how we want the x-axis label for this graph? (preview here: https://ucd-serg.github.io/serocalculator/preview/pr308/articles/enteric_fever_example.html).

@d-morrison d-morrison requested a review from kaiemjoy October 15, 2024 01:19
@kristinawlai
Copy link
Collaborator Author

kristinawlai commented Oct 30, 2024

  1. Why are we applying the log scale manually instead of with the log = TRUE option for autoplot.pop_data()?

Only because I forgot that it existed :). Updated to use log = TRUE

kaiemjoy
kaiemjoy approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@kaiemjoy kaiemjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good - remind me how to get the preview again?

@d-morrison
Copy link
Member

d-morrison commented Feb 3, 2025

i think this looks good - remind me how to get the preview again?

@kaiemjoy there's a bot-generated comment up above with the url: #308 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-morrison d-morrison d-morrison left review comments

@kaiemjoy kaiemjoy kaiemjoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kristinawlai @d-morrison @kaiemjoy